Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis pull request adds comprehensive documentation infrastructure for passwordless authentication using passkeys. It includes navigation category files for documentation organization, vocabulary entries for spell-checking, and a detailed guide covering WebAuthn integration approaches (Thunder Gate, Atomic API, Flow/Execute). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/content/guides/passkeys.mdx`:
- Around line 25-27: Replace the incorrect phrase "Both approaches follow the
WebAuthn standard ceremony:" with "All approaches follow the WebAuthn standard
ceremony:" in the paragraph that introduces the three WebAuthn approaches (the
line starting with "Both approaches follow the WebAuthn standard ceremony:"), so
the text correctly references all listed approaches.
There was a problem hiding this comment.
Pull request overview
Adds a new documentation guide explaining how to configure and use passkeys (WebAuthn) with Thunder across Hosted UI (Thunder Gate), Atomic APIs, and flow-based (/flow/execute) integrations.
Changes:
- Introduces a new
Passkeysguide covering prerequisites, configuration, and integration options. - Provides curl examples for atomic passkey registration/authentication endpoints.
- Documents how to use passkeys in orchestrated flows via
/flow/execute, plus troubleshooting tips.
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 638 638
Lines 42021 42021
Branches 2424 2424
=======================================
Hits 37710 37710
Misses 2339 2339
Partials 1972 1972
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
f3b6c1a to
c1ff2cd
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@docs/content/guides/passkeys.mdx`:
- Around line 171-251: Replace the phrase "not practical" with "impractical" in
the Registration with flow/execute section where the note starts with "Reminder:
Calling `/flow/execute`..." (search for the sentence containing "Calling
`/flow/execute` with a flow that only runs the passkey registration executor is
not practical") to tighten wording and match the style guide.
- Around line 29-43: Fix the grammar in the prerequisites bullet that reads "Use
a WebAuthn-capable browser (recent Chrome, Edge, Safari, or Firefox); You can
confirm support..." by making the clause after the semicolon lowercase ("you")
or by splitting into two sentences; update the sentence in
docs/content/guides/passkeys.mdx (look for the "Use a WebAuthn-capable browser"
bullet) so it becomes either "... Firefox); you can confirm support..." or "...
Firefox. You can confirm support..." to correct punctuation and capitalization.
- Around line 80-170: The OpenAPI spec in api/authentication.yaml uses the wrong
paths "/auth/webauthn/start" and "/auth/webauthn/finish"; update those path keys
to "/auth/passkey/start" and "/auth/passkey/finish" so the spec matches the
implemented endpoints and the docs in guides/passkeys.mdx (registration paths in
api/registration.yaml are already correct). Ensure any references/operationIds
that assume the old path are updated consistently to the new "/auth/passkey/*"
paths.
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
f822e0d to
c453653
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@docs/content/guides/passkeys.mdx`:
- Around line 29-43: Add a new "Assumptions" section immediately above the
existing "Prerequisites" heading in docs/content/guides/passkeys.mdx that
briefly lists the document's preconditions (e.g., the UI is served over HTTPS
with an RP ID-matching hostname, you have access to deployment config to add
allowed origins, users exist or can be provisioned in Thunder, and the reader is
using a WebAuthn-capable browser). Keep it short (one paragraph or bullet list)
and clearly labeled "Assumptions" so readers see these environment/context
requirements before the "Prerequisites" section.
- Around line 80-83: Update the headings in this MDX to Title Case (preserve the
existing heading levels/MDX hashes) — specifically change "Use Passkey Atomic
API in your app" to "Use Passkey Atomic API in Your App", "Registration flow" to
"Registration Flow" and apply the same Title Case fix to the other failing
headings referenced (the ones around the other ranges) so Vale lint passes; keep
the heading markers (##, ###) and surrounding content unchanged.
- Around line 254-258: Add a short "Next steps" section at the end of the
passkeys guide (file docs/content/guides/passkeys.mdx) that summarizes remaining
setup tasks and links to related docs; specifically include items to verify
allowed_origins and RP ID, ensure HTTPS for production, use the most recent
sessionToken for ceremonies, adjust authenticatorSelection for platform vs
roaming authenticators, and confirm the user exists (or note usernameless
flows), plus links to relevant reference pages or examples so readers know what
to do after finishing the guide.
- Around line 63-67: Replace the user-facing term "login" with "sign-in" in the
passkeys doc: change the bullet "Rendering login/registration prompts based on
the configured flow" to use "sign-in/registration prompts" (the phrase to update
is "Rendering login/registration prompts"), keep system-level uses of "login"
like "social login" untouched.
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
bb1f21e to
b1a3730
Compare
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
66cd475 to
92e04f7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.vale/styles/config/vocabularies/vocab/accept.txt:
- Around line 15-19: Add the token "usernameless" to the accepted vocabulary
file so Vale stops flagging it; update the vocab list in accept.txt by inserting
either "usernameless" (and/or a case-insensitive pattern like "[Uu]sernameless")
alongside the other entries (e.g., near "[Pp]asswordless") so the lint rules
recognize the term used in passkeys.mdx.
6da4574 to
ff9cc7b
Compare
ff9cc7b to
fdc3af3
Compare
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Outdated
Show resolved
Hide resolved
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Outdated
Show resolved
Hide resolved
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Show resolved
Hide resolved
docs/content/guides/authentication/passwordless-authentication/passkeys.mdx
Outdated
Show resolved
Hide resolved
4829944 to
a071423
Compare
a071423 to
45162fa
Compare
Purpose
This pull request adds comprehensive documentation for configuring and using passkeys (WebAuthn-based passwordless authentication) with Thunder. The new guide covers multiple integration approaches, including the hosted UI, atomic APIs, and flow-based APIs, and provides step-by-step instructions, sample API calls, and troubleshooting tips.
New documentation: Passkeys integration guide
The most important changes are:
Passkeys overview and prerequisites:
Integration approaches:
/register/passkey/*and/auth/passkey/*endpoints./flow/execute, including handling WebAuthn ceremonies and flow steps. (F3f979Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks
Summary by CodeRabbit