feature: Add grouping for Domains #266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The thing that is going to need to be tested here is with relationships that cross domains. Please be sure to try out cross-domain relationships and see the effects. We likely need to hide certain UI elements & buttons for viewing items that are not in the group that is currently being viewed. |
Contributor
Author
|
Sorry for dropping the ball here, just letting you know that I am looking into it now and will try to fix this during coming week :) |
- Allow a domain to have a :group. - When defining ash_admin routes, allow to filter on a domain group. - Test: For the ash_admin_test.exs to ensure the group is accessible. - Test: For verifying the behaviour on page_live. - Test/refactor: DomainA and DomainB, to easier test one against the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull-request implementing grouping of domains. So that we can support multiple-admin panels, as mentioned in #265
Tests written, and I've used it locally in a project and seems to work fine.
refute htmlchecks in the test when one was namedDomainand the otherDomainBas one contained the other 😂Contributor checklist