Conversation
…esolution Steps inside a `switch` block couldn't reference external steps via `result(:step_name)` when running with async execution. This was because `Step.Switch` didn't implement the `nested_steps/1` callback, so the planner couldn't see the nested steps' dependencies and create proper edges in the dependency graph. Without proper dependency edges, the Switch step could run before its nested steps' dependencies completed, causing a "step cannot be found" error when the emitted steps were planned at runtime. Closes #273
barnabasJ
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nested_steps/1callback forReactor.Step.Switch@impl trueannotation to existingrun/3function (was missing)nested_steps/1callbackRoot Cause
Step.Switchdidn't implementnested_steps/1, so the planner couldn't see nested steps' dependencies. Without proper dependency edges:The existing test used
async?: falsewhich masked the race condition.Test plan
async?: truenested_steps/1callbackCloses #273