fix: remove unused async options from Reactor.undo/3#292
Merged
Conversation
`Reactor.undo/3` accepted async-related options (`async?`, `max_concurrency`, `timeout`, `max_iterations`) but never used them. The undo operation is intentionally sequential - this is correct saga behaviour as the forward dependency graph cannot be reliably inverted for undo operations. This is a breaking change: passing removed options will now result in a Spark.Options validation error. Also fixes a flaky timing test in executor_test.exs by removing an unnecessarily tight upper bound on elapsed time. Closes #291
jimsynz
force-pushed
the
fix/291-remove-unused-undo-options
branch
from
3d8b1e9 to
7b620b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async?,max_concurrency,timeout,max_iterations) fromReactor.undo/3Breaking Change
Passing removed options to
Reactor.undo/3will now result in a Spark.Options validation error. Users need to remove these options from their undo calls.Test plan
mix check --no-retry)test/reactor_test.exspasstest/reactor/dsl/compose_test.exspassmix docs)Closes #291