Open
Conversation
react-native projects use Babel 6, is incompatible with this project's .babelrc. The babelrc file for an npm module should not be in the npm package at all, since transpilation should be done before publishing to npm, so we add .babelrc file to the npmignore file. See similar issue in redux-thunk for more details reduxjs/redux-thunk#43
|
This should be ready to merge. @ashaffer Let me know if you need contributor support! There are only a few issues, and I doubt this will iterate much given how small the scope is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-native projects use Babel 6 and the current .babelrc
in version 0.1.12 published on npm is incompatible with Babel 6.
The babelrc file for an npm module should not be in the npm
package at all, since transpilation should be done before publishing
to npm, so we add .babelrc file to the npmignore file.
See similar issue in redux-thunk for more details
reduxjs/redux-thunk#43