Updates to ES6 + Rollup #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple browserify and babel set up. Also browserifies tests.
The public API is now in 'src/api.js' and the 'enum.js' file will be refactored to be just the constructing logic. The assign functionality has been created, and should be fine for version 1.0, will write more tests later.
Playing with rollup configurations... I don't like having a bunch of config files but the separation is nicer. Will probably try to combine the best of both styles.
seems crazy to use rollup into browserify but I want them shims. ...might need to make rollup-plugin-browserify magic
Also removed old build script file, moved back to simple npm scripts build setup. Also brought in ShellJS to keep things cross platform and not have to double down on specific build processes. Also un-did the "dependency injection" style test files.
Made some updates to the prototype, toString, toJSON, and others Added support for Symbols as keys and values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR for the fancy github diff