Skip to content

Conversation

@vmalyk
Copy link

@vmalyk vmalyk commented Oct 1, 2020

Hi!

Added common improvement to use Composer Information for show in "Bundles" Grid by Pimcore\Extension\Bundle\Traits\PackageVersionTrait. In addition I've fixed couple things:

  • Removed non-valid class name
  • Removed getDescription, becuase it works the same and return empty string by default. Since Pimcore 6.7 it returns description from composer.json in PackageVersionTrait.
  • getSolutionVersion() - it's not present in abstract classes or interfaces, but might be used for some internal tools. I suggest to use $this->getVersion instead copy code or if method isn't used - remove it.

Please review,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant