redis_prefix correction with tests passing #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using multiple recommenders in a script, eg for cross validation, the redis_prefix was the same for input matrices of all recommenders. What's more, all recommenders had access to all input matrices of all other recommenders. This patch fixes these problems and enables testing 2 different recommenders in a script to see if their difference of performance is statistically significant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple recommenders in a script, eg for cross validation,
the redis_prefix was the same for input matrices of all recommenders.
What's more, all recommenders had access to all input matrices of all
other recommenders.
This patch fixes these problems and enables testing 2 different
recommenders in a script to see if their difference of performance is
statistically significant.
Tests really pass now