expand user-supplied args #118
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Changes the
rolluprule to expand location expressions in user-supplied args.For example, as if this PR one could:
Typical usages of rollup will not need this feature and will remain unaffected, however, rollup does support custom command line arguments and in those cases it can be useful to pass a build-time data file. Location expansion allows users to express this without hardcoding bazel file structures (see the above example).
Changes are visible to end-users: yes
Test plan
I'm happy to add new tests, just let me know. The existing tests don't appear to check the contents of the bundle which would be necessary to fully test this feature. That said it's relatively straightforward so I could see this not requiring new tests.