feat: print a report #2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| lcov_build = ctx.bazel.build( | ||
| "@lcov", | ||
| events = True, | ||
| bazel_flags = ["--build_runfile_links"], | ||
| ) | ||
| lcov = runnable(ctx, "@@lcov+//:lcov") | ||
| for event in lcov_build.events(): | ||
| lcov.event(event) |
There was a problem hiding this comment.
The lcov binary is built with ctx.bazel.build("@lcov", …), but @lcov is not a legal Bazel label – an external repository must be addressed with a full label such as @lcov//:lcov. Because no @@lcov+//:lcov target is actually built, the runnable never sees a target_completed event, _determine_entrypoint returns None, and lcov.spawn will fail before any report is printed. The build call should use the same explicit label that the runnable later tries to execute so the lcov binary is produced and can be run.
Useful? React with 👍 / 👎.
No description provided.