Skip to content

Add PHP 8.4 support and require PHP 8.3+ #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sylfabre wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add PHP 8.4 support and require PHP 8.3+ #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c24fb4
Add PHP 8.4 support and require PHP 8.3+
sylfabre Jan 7, 2026
7073a57
Fix PHP 8.4 implicit nullable parameter deprecation and PHPStan issue
sylfabre Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.3']
php-versions: ['8.3', '8.4']
dependency-versions: ['lowest', 'highest']
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"symfony/security-core": "^6.4|^7.0"
},
"require": {
"php": "^8.2",
"php": "^8.3",
"symfony/framework-bundle": "^6.4|^7.0",
"doctrine/dbal": "^2.10|^3.0",
"symfony/serializer": "^6.4|^7.0",
Expand Down
1 change: 1 addition & 0 deletions src/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
{
$treeBuilder = new TreeBuilder('log');

/** @phpstan-ignore class.notFound (PHPStan issue with Symfony Config generic types) */
$treeBuilder->getRootNode()

Check failure on line 17 in src/DependencyInjection/Configuration.php

View workflow job for this annotation

GitHub Actions / build (8.3, lowest) 

No error with identifier class.notFound is reported on line 17.
->children()
->arrayNode('log_filters')
->addDefaultsIfNotSet()
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/UnsupportObjectException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

class UnsupportObjectException extends \DomainException
{
public function __construct($object, $code = 0, \Throwable $previous = null)
public function __construct($object, $code = 0, ?\Throwable $previous = null)
{
$message = sprintf('Unhandled object of class %s', $object::class);
parent::__construct($message, $code, $previous);
Expand Down
Loading