You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I add two new combine functions. One is simply 'min' - very similar to what exists already.
The other one is 'median', which required some per-block processing. This is probably slower - I made no tests for performance yet.
Merging #336 (05a9646) into main (185dae1) will increase coverage by 0.38%.
The diff coverage is 98.03%.
❗ Current head 05a9646 differs from pull request most recent head 298424c. Consider uploading reports for the commit 298424c to get more accurate results
Thanks for the pull request! I'll try and take a look at this soon! In the meantime, I noticed that some of the code has been re-formatted - could you run tox -e codestyle to format it back and commit the changes?
Thanks for the pull request! I'll try and take a look at this soon! In the meantime, I noticed that some of the code has been re-formatted - could you run tox -e codestyle to format it back and commit the changes?
My IDE was complaining that formatting style is non-standard, that's why I changed it. Was this non-standard style intended? I can change it back of course
@minzastro - sorry for not getting back to this. Now that we use dask internally in a few places in reproject I think we should also consider using dask to handle the median calculation to avoid having to do all the block handling ourselves. I'll open an alternative PR to try this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add two new combine functions. One is simply 'min' - very similar to what exists already.
The other one is 'median', which required some per-block processing. This is probably slower - I made no tests for performance yet.