Fixed find_optimal_celestial_wcs for cases where SkyCoords can't be stacked#584
Draft
astrofrog wants to merge 1 commit intoastropy:mainfrom
Draft
Fixed find_optimal_celestial_wcs for cases where SkyCoords can't be stacked#584astrofrog wants to merge 1 commit intoastropy:mainfrom
astrofrog wants to merge 1 commit intoastropy:mainfrom
Conversation
… stacked into a single SkyCoord
Cadair
reviewed
Feb 5, 2026
Comment on lines
+217
to
+218
| # they can set it manually. If we weren't able to stack the coordinates | ||
| # to a single SkyCoord, we just use the first reference value. |
Member
There was a problem hiding this comment.
I'm not sure I love this change in behaviour. If we are going to have this shift, then we are going to have to raise a warning. Would it be better to do a longhand mean?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 91.06% 90.83% -0.24%
==========================================
Files 30 30
Lines 1858 1865 +7
==========================================
+ Hits 1692 1694 +2
- Misses 166 171 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #583 - fall back to converting coordinates individually. This will be slower but also maybe not slow enough to really matter. I guess the question is whether if we do want to do this approach we should have a warning that this is happening.
This needs a test if we want to keep it.