Skip to content

Fixed find_optimal_celestial_wcs for cases where SkyCoords can't be stacked#584

Draft
astrofrog wants to merge 1 commit intoastropy:mainfrom
astrofrog:fix-skycoord-stack
Draft

Fixed find_optimal_celestial_wcs for cases where SkyCoords can't be stacked#584
astrofrog wants to merge 1 commit intoastropy:mainfrom
astrofrog:fix-skycoord-stack

Conversation

@astrofrog
Copy link
Member

@astrofrog astrofrog commented Feb 5, 2026

Possible fix for #583 - fall back to converting coordinates individually. This will be slower but also maybe not slow enough to really matter. I guess the question is whether if we do want to do this approach we should have a warning that this is happening.

This needs a test if we want to keep it.

Comment on lines +217 to +218
# they can set it manually. If we weren't able to stack the coordinates
# to a single SkyCoord, we just use the first reference value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I love this change in behaviour. If we are going to have this shift, then we are going to have to raise a warning. Would it be better to do a longhand mean?

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.83%. Comparing base (ff563b9) to head (74f2b87).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
reproject/mosaicking/wcs_helpers.py 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   91.06%   90.83%   -0.24%     
==========================================
  Files          30       30              
  Lines        1858     1865       +7     
==========================================
+ Hits         1692     1694       +2     
- Misses        166      171       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants