chore: update meetings.json and newsrooom_videos.json#5188
Conversation
asyncapi-bot
requested review from
Mayaleeeee,
anshgoyalevil,
asyncapi-bot-eve,
princerajpoot20 and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis pull request updates the newsroom videos configuration by removing one video entry and adding multiple new video entries to the JSON array, maintaining the consistent object structure with image_url, title, description, and videoId fields. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5188 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5188--asyncapi-website.netlify.app/ |
asyncapi-bot
deleted the
update-meetings/75cd0ca8485bb6d9945d68c058077b6421c5fc18
branch
github-project-automation
bot
moved this from To Be Triaged
to Done
in Website - Kanban
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@config/newsroom_videos.json`:
- Around line 110-127: Two entries share the same "title" ("AsyncAPI Community
WG Meeting , Tuesday July 29th 2025") and "description" URL but different
videoId values (7vvdmDVZPX0 and xD5smwg6az8); either remove the duplicate or
make the titles distinct (e.g., append "Part 1"/"Part 2" or add "(Recording
A/B)") so users can tell them apart—update the objects with videoId 7vvdmDVZPX0
and/or xD5smwg6az8 accordingly.
- Around line 104-109: Fix the typo and extra space in the title field for the
JSON entry with "videoId": "ncOFU__8hLM" by changing the "title" value from
"AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025" to "AsyncAPI
Community WG Meeting, Tuesday August 12th 2025"; additionally add a
normalization/sanitization step in the generator that trims spaces before
punctuation and applies common typo corrections (e.g., map "Auguest" → "August")
so future titles are auto-fixed at generation time.
- Around line 26-31: The newsroom_videos entry with videoId "yRjdA0DYvBM" (title
"AsyncAPI Community WG Meeting") has an empty "description": "" which will
render blank; update that object's "description" value to a meaningful string
(for example the community issue/meeting URL used by other entries or a short
meeting summary) so the UI shows content instead of an empty slot.
| { | ||
| "image_url": "https://i.ytimg.com/vi/yRjdA0DYvBM/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting", | ||
| "description": "", | ||
| "videoId": "yRjdA0DYvBM" | ||
| }, |
There was a problem hiding this comment.
Empty description field will render a blank on the newsroom page.
The entry for yRjdA0DYvBM has "description": "". If the UI always renders this field, viewers will see an empty description slot. Consider adding at least the community issue URL (as other meeting entries do) or a short summary once available.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@config/newsroom_videos.json` around lines 26 - 31, The newsroom_videos entry
with videoId "yRjdA0DYvBM" (title "AsyncAPI Community WG Meeting") has an empty
"description": "" which will render blank; update that object's "description"
value to a meaningful string (for example the community issue/meeting URL used
by other entries or a short meeting summary) so the UI shows content instead of
an empty slot.
| { | ||
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/2014.", | ||
| "videoId": "ncOFU__8hLM" | ||
| }, |
There was a problem hiding this comment.
Typo in title: "Auguest" → "August" (and extra space before comma).
The title on Line 106 reads "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025" — two issues:
Auguestshould beAugust.- There is an extraneous space before the comma, consistent with several other added titles (Lines 94, 112, 118, 124).
If these titles are sourced directly from YouTube metadata, a normalisation/sanitisation step in the generating script would prevent future occurrences.
✏️ Suggested correction
- "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025",
+ "title": "AsyncAPI Community WG Meeting, Tuesday August 12th 2025",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/2014.", | |
| "videoId": "ncOFU__8hLM" | |
| }, | |
| { | |
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting, Tuesday August 12th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/2014.", | |
| "videoId": "ncOFU__8hLM" | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@config/newsroom_videos.json` around lines 104 - 109, Fix the typo and extra
space in the title field for the JSON entry with "videoId": "ncOFU__8hLM" by
changing the "title" value from "AsyncAPI Community WG Meeting , Tuesday Auguest
12th 2025" to "AsyncAPI Community WG Meeting, Tuesday August 12th 2025";
additionally add a normalization/sanitization step in the generator that trims
spaces before punctuation and applies common typo corrections (e.g., map
"Auguest" → "August") so future titles are auto-fixed at generation time.
| { | ||
| "image_url": "https://i.ytimg.com/vi/7vvdmDVZPX0/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "7vvdmDVZPX0" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/SaIPQaROWsc/hqdefault.jpg", | ||
| "title": "First Meeting of New Governance Board , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1989.", | ||
| "videoId": "SaIPQaROWsc" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/xD5smwg6az8/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "xD5smwg6az8" | ||
| }, |
There was a problem hiding this comment.
Two entries with identical title and description for July 29th 2025 — users cannot distinguish them.
Lines 110–115 (videoId: 7vvdmDVZPX0) and Lines 122–127 (videoId: xD5smwg6az8) share the same title and the same description URL. If these are genuinely two separate recordings of the same meeting (e.g., split into parts), their titles should differentiate them (e.g., append "Part 1" / "Part 2"). If one is a duplicate, it should be removed.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@config/newsroom_videos.json` around lines 110 - 127, Two entries share the
same "title" ("AsyncAPI Community WG Meeting , Tuesday July 29th 2025") and
"description" URL but different videoId values (7vvdmDVZPX0 and xD5smwg6az8);
either remove the duplicate or make the titles distinct (e.g., append "Part
1"/"Part 2" or add "(Recording A/B)") so users can tell them apart—update the
objects with videoId 7vvdmDVZPX0 and/or xD5smwg6az8 accordingly.
2 participants
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit