Skip to content

Comments

add dependencies, change SHA module name for Linux systems#1

Open
tenbaht wants to merge 1 commit intoatdotde:masterfrom
tenbaht:master
Open

add dependencies, change SHA module name for Linux systems#1
tenbaht wants to merge 1 commit intoatdotde:masterfrom
tenbaht:master

Conversation

@tenbaht
Copy link

@tenbaht tenbaht commented Jan 28, 2019

Hi Robert,

thank you very much for that useful little script!
Using it on Mint 19 (Ubuntu-like) I had to figure out the required dependency packages and change the Digest::SHA module name. Maybe you would like to include these changes?

Michael

Copy link
Owner

@atdotde atdotde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit description could be slightly more verbatim. Please add a signed off by line (git commit does this for you with option -s) so it is clear that this is your code and you are happy with publishing it under an open license.

A quick git commit --amend should do the job for you.

This script depends on the Digest::SHA and the Term::Readkey perl modules.
On Debian-based systems (Debian, Ubuntu, Mint etc.) they can be installed by

sudo apt install libdigest-sha-perl libterm-readkey-perl
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. I wrote this on a Mac and had these modules already installed (I don't know if I did this in the past manually or they were preinstalled.

There is also a perl specific way to install modules:

perl -M CPAN -e shell
install Digest::SHA
install Term::ReadKey

That should work universally. But your suggestions are fine if you want to worry just about your distribution handling updates.


# Functional style
use Digest::SHA1 qw(sha1 sha1_hex sha1_base64);
use Digest::SHA qw(sha1 sha1_hex sha1_base64);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

while(1) {
print "Password to check:\n";
ReadMode ( 'noecho' );
# ReadMode ( 'noecho' );
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This I don't like. What did you turn off the no echo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants