Added new parametrized CustomChromium #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyrzyk
reviewed
Mar 3, 2020
...kotlin/com/atlassian/performance/tools/infrastructure/api/browser/chromium/CustomChromium.kt
Show resolved
Hide resolved
dagguh
approved these changes
Mar 3, 2020
Contributor
|
@wyrzyk, when you add a comment as a code owner, you're automatically reviewing it on behalf of the JPT team. In general it makes sense, you started reviewing it, it's natural to expect you to follow it further as an owner. However, if you don't plan to push the PR further, then let's re-add the team as a reviewer, so that a maintainer can notice it in their "open PRs list", merge it and release it. |
Contributor
|
@Mac-Ste released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new parametrized CustomChromium allowing to use specified URIs for browser and driver