Open
Conversation
Collaborator
|
That's cool. I'd love however to find a way to run both 18 and 19, as I worry something might be different and most of the consumers are still on v18 🤔 |
Author
|
We could do something like: const version = +React.version.split('.')[0];
if (version > 18) {
expect(selector).toHaveBeenCalledTimes(2);
} else {
expect(selector).toHaveBeenCalledTimes(withStrict(2));
}We could add the version check to utils so it's abstracted a little. Ideally we could add the version check into Also, in case it's not clear, everything seems to work fine between 18 and 19 - it's just the tests that needed to be tweaked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped versions and fixed appropriate tests. I think the revisions to the tests were necessarily mostly due to: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#strict-mode-improvements
Take a look, though, and let me know if I missed anything.