JPERF-570: clean up log4j deps #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It's working, but not auto-merging yet. We can get cleaner test classpath locks after ssh-ubuntu POM cleanup. |
dagguh
force-pushed
the
issue/JPERF-570-clean-up-log4j-deps
branch
from
d3803d5 to
074b1f4
Compare
Yes, log4j-api is part of ssh API: `SshConnection.execute(..., Level)`.
It only cleans up local locks. It has no bearing on the POM.
dagguh
force-pushed
the
issue/JPERF-570-clean-up-log4j-deps
branch
from
074b1f4 to
b9b31bb
Compare
pczuj
approved these changes
Mar 23, 2023
ewefie
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, log4j-api is part of ssh API:
SshConnection.execute(..., Level).Also, harvest log4j fix from jvm-tasks:1.2.4. It only cleans up local locks. It has no bearing on the POM.