Skip to content

Conversation

@FirasSahliADLinktech
Copy link

create waitset entity and its functionalities and write unit tests for them

@gabrik
Copy link
Contributor

gabrik commented Jul 30, 2020

Is this PR containing also the code for all the older ones?
It seems so from the commit-id, I just want to be sure

@FirasSahliADLinktech FirasSahliADLinktech force-pushed the create_waitset branch 2 times, most recently from 2e87f4e to 87bddcb Compare August 4, 2020 14:23
add travis to the repository
@FirasSahliADLinktech FirasSahliADLinktech force-pushed the create_waitset branch 3 times, most recently from 96535b8 to 60ac423 Compare August 4, 2020 16:23
FirasSahliADLinktech and others added 23 commits August 7, 2020 13:48
trying to get it working
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
…ssed on them

Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
…d flexy_reader

Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
…d fot some tests and examples

Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
@FirasSahliADLinktech FirasSahliADLinktech force-pushed the create_waitset branch 4 times, most recently from c5845a2 to 27f8f08 Compare August 26, 2020 08:16
gabrik added 5 commits August 26, 2020 10:23
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
gabrik and others added 13 commits September 3, 2020 13:41
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
@gabrik
Copy link
Contributor

gabrik commented Sep 18, 2020

Looks good from a Python point-of-view.
I still see too much output coming from the tests, that should be avoided.
@kydos can you check it from DDS point-of-view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants