Added bracket mark in gutter and Show in Gutter submenu in package#180
Added bracket mark in gutter and Show in Gutter submenu in package#180RobertoOropezaG wants to merge 3 commits intoatom:masterfrom
Conversation
lib/bracket-matcher-view.coffee
Outdated
There was a problem hiding this comment.
Generally the language packages call ( brace.round, so round-brace might be a better name here
lib/bracket-matcher-view.coffee
Outdated
|
The CI build is currently failing because of some coffeelint errors. I've added comments on where the errors are occurring, so if you could fix those, that would be 🍧. In addition, it would be great if you could add some specs to test for this new behavior. |
|
Not too sure on the /cc @atom/feedback |
|
@RobertoOropezaG Just want to chime in and say this is slick! 👍 |
|
I agree with @50Wliu, I think the brace terminology should be replaced with bracket. The fact language grammars use brace is purely through inheriting that from TextMate. We should strive for consistency when and where we can. Other than that and adding some tests, this looks awesome! |
|
Hey, can I help with this merge? This feature has been done a month+ ago... |
This PR has conflicts right now, so the first step in getting this back on track would be to fix those. |
|
any news on this ? |
|
Hi. |
|
Hello! How can I help move this forward? I'm not familiar with Atom development but I tried to fork this repo and solve the conflicts to come up with a PR but seems I can uninstall How can I disable the default package and use mine instead? Thanks for all the help and work on Atom =) |
|
@douglas We have a guide for contributing to official Atom packages in the flight manual https://flight-manual.atom.io/hacking-atom/sections/contributing-to-official-atom-packages/ |
9 participants
Hi, I wanted this feature that I use in ST3 BracketHighlighter package, I couldn't find it anywhere and also saw other users asking for it (#97)
Best Regards, Roberto