issue-107: Modify Searcher to keep track of when a search is being performed and update BusyIndicator component by nikhilj13 · Pull Request #106 · attivio/suit

nikhilj13 · 2019-04-18T18:44:24Z

Adds a new state variable isSearching to the searcher to keep track of when the system is searching. Also updates the BusyIndicator component to have a 'spinnyCentered' type spinner that can be shown when a search is being performed.

Below is an example of BusyIndicator with type 'spinnyCentered' being used in SearchUI:

BusyIndicator is configurable through SearchUI's configuration.properties file. Here is an example:

  BusyIndicator: {
	// type of BusyIndicator that should be shown - available types are elipsis, spinny and spinnyCentered 
	// spinnyCentered shows a big spinner in the center of its container with a message
	type: 'spinnyCentered',
	// name of the spinner image with the extension placed in searchui/frontend/src/img folder
	spinner: 'img/spinner.gif',
	// height for the spinner
	spinnerHeight: '50%',
	// width for the spinner
	spinnerWidth: '50%',
	// text that should be displayed with the spinner
  	message: 'Loading Results...',
  },```

- Added a new state isSearching in Searcher.js to keep track of when a search is being done - Added a new Spinner component

updated class name

- Added displayName to Spinner - Added Spinner to the styleguide

luigivaldez

Does the BusyIndicator component not do what you wanted this to do?
https://attivio.github.io/suit/styleguide/index.html#busyindicator
If you need to be able to use a custom image, can you change the existing one to take a property?

luigivaldez · 2019-04-18T21:44:46Z

src/components/Searcher.js

 type SearcherProps = {
-  location: PropTypes.object.isRequired;
-  history: PropTypes.object.isRequired;
+  location: PropTypes.object.isRequired,


Why are all of these semicolons changed into commas? Was this your formatter issue?

Yes, but I'm not getting any lint errors because of this

luigivaldez · 2019-04-18T21:46:39Z

src/components/Searcher.js

-    return facetFilters.map((facetFilter: FacetFilter): string => {
-      return `${facetFilter.facetName},+${facetFilter.bucketLabel},+${facetFilter.filter}`;
-    });
+    return facetFilters.map(


Ditto here and in deserializeFacetFilter() below... it'll be good to revert this formatting change which is unnecessary, to make it simpler to do merges.

Okay, I'll revert it.

luigivaldez · 2019-04-18T21:48:01Z

src/components/Searcher.js

-        this.props.history.push(`?${updatedQueryString}`);
-      }
-    });
+    const localCallBack = () => {


I was going to say "Can you name this something more descriptive?" Although, I think it's clearer what you're doing if you just include this function inline as the second parameter to setState(). For example:

this.setState({ isSearching: true, }, () => { // start the search... });

Sure, makes sense

- Fixed formaating issues

fixed formatting

luigivaldez

See inline comments.... Will add comments to the Search UI side of this too...

luigivaldez · 2019-07-16T15:13:35Z

src/components/Searcher.js

    if (state.debug !== this.props.debug) {
      basicState.debug = state.debug;
    }
+    basicState.isSearching = this.state.isSearching;


I don't think it makes sense to save the isSearching flag in the URL...

luigivaldez · 2019-07-16T15:16:15Z

src/components/BusyIndicator.js

+        return (
+          <div className="attivio-spinner">
+            {this.renderBusySymbol()}
+            <br />


If there's no messageToShow, you probably don't want to add these <br>s and the message at all.

luigivaldez · 2019-07-16T15:22:58Z

src/components/BusyIndicator.js

+import Configurable from './Configurable';
 import spinnyImage from '../img/spinner.gif';

 type BusyIndicatorType = 'ellipsis' | 'spinny';


You need to add 'spinnyCentered' here...

nikhilj13 added 2 commits April 18, 2019 13:51

Added Spinner

813146e

- Added a new state isSearching in Searcher.js to keep track of when a search is being done - Added a new Spinner component

Update Spinner.js

1a56318

updated class name

nikhilj13 changed the title ~~Add a new Spinner Component and changes to Searcher to keep track of when a search is being performed~~ Add a new Spinner Component and made changes to Searcher to keep track of when a search is being performed Apr 18, 2019

nikhilj13 changed the title ~~Add a new Spinner Component and made changes to Searcher to keep track of when a search is being performed~~ Added a new Spinner Component and made changes to Searcher to keep track of when a search is being performed Apr 18, 2019

nikhilj13 changed the title ~~Added a new Spinner Component and made changes to Searcher to keep track of when a search is being performed~~ Add a new Spinner Component and modify Searcher to keep track of when a search is being performed. Apr 18, 2019

nikhilj13 mentioned this pull request Apr 18, 2019

suit-issue-107: Use updated BusyIndicator from SUIT attivio/searchui#75

Open

1 task

nikhilj13 changed the title ~~Add a new Spinner Component and modify Searcher to keep track of when a search is being performed.~~ issue-107: Add a new Spinner Component and modify Searcher to keep track of when a search is being performed. Apr 18, 2019

Updated Spinner

3df804c

- Added displayName to Spinner - Added Spinner to the styleguide

luigivaldez reviewed Apr 18, 2019

View reviewed changes

nikhilj13 added 4 commits April 19, 2019 12:19

Update Searcher.js

dbe24a3

- Fixed formaating issues

Update Searcher.js

116c8be

fixed formatting

Merged Spinner component into BusyIndicator

79160ce

Delete Spinner.js

df42497

nikhilj13 changed the title ~~issue-107: Add a new Spinner Component and modify Searcher to keep track of when a search is being performed.~~ issue-107: Modify Searcher to keep track of when a search is being performed and update BusyIndicator component Apr 19, 2019

luigivaldez requested changes Jul 16, 2019

View reviewed changes

klk1010 added the merge conflicts This PR has a merge conflict that needs to be resolved. label Sep 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

issue-107: Modify Searcher to keep track of when a search is being performed and update BusyIndicator component#106

issue-107: Modify Searcher to keep track of when a search is being performed and update BusyIndicator component#106
nikhilj13 wants to merge 7 commits intoattivio:masterfrom
nikhilj13:show-spinner-while-searching

nikhilj13 commented Apr 18, 2019 •

edited

Loading

Uh oh!

luigivaldez left a comment •

edited

Loading

Uh oh!

luigivaldez Apr 18, 2019

Uh oh!

nikhilj13 Apr 19, 2019

Uh oh!

luigivaldez Apr 18, 2019

Uh oh!

nikhilj13 Apr 19, 2019

Uh oh!

luigivaldez Apr 18, 2019

Uh oh!

nikhilj13 Apr 19, 2019

Uh oh!

luigivaldez left a comment

Uh oh!

luigivaldez Jul 16, 2019

Uh oh!

luigivaldez Jul 16, 2019

Uh oh!

luigivaldez Jul 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

nikhilj13 commented Apr 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luigivaldez left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luigivaldez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nikhilj13 commented Apr 18, 2019 •

edited

Loading

luigivaldez left a comment •

edited

Loading