Provide the official container image #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comuttun
force-pushed
the
feature/provide-official-container-image
branch
6 times, most recently
from
1b659b2 to
270f5bd
Compare
- Changed LOGIN_PROVIDER to app - Changed UPLOAD_DESTINATION to s3
comuttun
force-pushed
the
feature/provide-official-container-image
branch
3 times, most recently
from
2fe5533 to
329e423
Compare
added 4 commits
February 24, 2017 05:58
Implemented `./sharedocs package:docker` to build an official docker container image, and implemented `./sharedocs publish:docker` to push an official docker container image to Dockerhub.
comuttun
force-pushed
the
feature/provide-official-container-image
branch
from
329e423 to
986af24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please merge #18 and #19 before this
This fixes #16 .
Implemented
./sharedocs package:dockerto build the official dockercontainer image, and implemented
./sharedocs publish:dockerto push theofficial docker container image to Dockerhub.
In addition, modified
.travis.ymlto build/push the official docker container image automatically.Note: To push the docker container image successfully, configuring env variable
DOCKER_USERNAMEandDOCKER_PASSWORDare required on TravisCI.The official container image repository is sharedocs/sharedocs-standalone, so changed
docker-compose.ymlto refer that.