Skip to content

Conversation

@drux007
Copy link
Member

@drux007 drux007 commented Jan 26, 2026

Ensures the license year stays always up to date, by setting its upper bound to -present in all files.

Summary by Sourcery

Chores:

  • Replace fixed end year in README with ‘-present’ to keep it up to date
  • Replace fixed end year in conf.py with ‘-present’ to keep it up to date and update the previous license owner

Summary by Sourcery

Update project copyright notices to use an open-ended year range and reflect correct ownership history.

Documentation:

  • Update README copyright line to use an open-ended year range for audEERING GmbH.

Chores:

  • Adjust Sphinx configuration copyright string to use an open-ended year range and accurately list past and current rights holders.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 26, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates copyright year ranges to use an open-ended 'present' upper bound and aligns copyright ownership information in both the README and Sphinx configuration.

File-Level Changes

Change Details Files
Make README license year range open-ended.
  • Replace fixed end year 2023 with 'present' in the audEERING GmbH copyright line
  • Leave historical copyright ranges and authors unchanged
README.md
Align Sphinx documentation copyright string with updated license years and owners.
  • Update audEERING GmbH copyright range to '2016-present' instead of '2013-2023'
  • Explicitly list 2013-2015 audEERING UG (haftungsbeschraenkt) as a separate range
  • Preserve TU München, MMK 2008-2013 attribution while restructuring the copyright string
doc/sphinx/conf.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Consider making the copyright line in conf.py consistent with README.md in terms of year ranges and company-name formatting (including use of commas and wording like UG (haftungsbeschränkt) vs UG (haftungsbeschraenkt)), so the attribution is uniform across the project.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider making the copyright line in `conf.py` consistent with `README.md` in terms of year ranges and company-name formatting (including use of commas and wording like `UG (haftungsbeschränkt)` vs `UG (haftungsbeschraenkt)`), so the attribution is uniform across the project.

## Individual Comments

### Comment 1
<location> `doc/sphinx/conf.py:6-9` </location>
<code_context>

 project = 'openSMILE'
-copyright = '2013-2023 audEERING GmbH and 2008-2013 TU München, MMK'
+copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschraenkt) and 2008-2013 TU München, MMK'
 author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller'
 version = conanfile.OpensmileConan.version
</code_context>

<issue_to_address>
**suggestion (typo):** Consider using the proper umlaut spelling for 'haftungsbeschränkt' for legal/branding accuracy.

If UTF-8 is fully supported in the build and docs pipeline, consider using `haftungsbeschränkt` to reflect the official entity name. If ASCII-only is required here, a brief comment or note in the docs would help prevent oscillating changes in the future.

```suggestion
project = 'openSMILE'
# Note: use proper umlaut spelling to match the official legal entity name.
copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschränkt) and 2008-2013 TU München, MMK'
author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller'
version = conanfile.OpensmileConan.version
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines 6 to 9
project = 'openSMILE'
copyright = '2013-2023 audEERING GmbH and 2008-2013 TU München, MMK'
copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschraenkt) and 2008-2013 TU München, MMK'
author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller'
version = conanfile.OpensmileConan.version
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (typo): Consider using the proper umlaut spelling for 'haftungsbeschränkt' for legal/branding accuracy.

If UTF-8 is fully supported in the build and docs pipeline, consider using haftungsbeschränkt to reflect the official entity name. If ASCII-only is required here, a brief comment or note in the docs would help prevent oscillating changes in the future.

Suggested change
project = 'openSMILE'
copyright = '2013-2023 audEERING GmbH and 2008-2013 TU München, MMK'
copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschraenkt) and 2008-2013 TU München, MMK'
author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller'
version = conanfile.OpensmileConan.version
project = 'openSMILE'
# Note: use proper umlaut spelling to match the official legal entity name.
copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschränkt) and 2008-2013 TU München, MMK'
author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller'
version = conanfile.OpensmileConan.version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant