- Enhanched the require rule with an extra required attribute from.bind, this or the from are now required#194
Conversation
…nd, this or the from are now required. - Removed unused imports/parameters; - Some other code clean up and update the README.MD;
|
@LittleGnome We actually don't support binding the |
|
But when we use it as followed, it's totally fine, but Aurelia template linter doesn' |
|
@LittleGnome I have to be honest, I'm not sure how that is working. Let me loop in @bigopon . Perhaps there was some change at some point I'm unaware of that enables that to work. |
|
Hello @bigipon, do you have some time to look into this pull request? |
|
Oops, missed this. Ill ha e a look in a few hours |
| return; | ||
|
|
||
| let result = attrs.find(x => (<any>x).name == 'from'); | ||
| let result = attrs.find(x => x.name === 'from' || x.name === 'from.bind'); |
There was a problem hiding this comment.
we don't support fromt.bind in <require/>, may I know why this was added?
Make sure you check the following:
developbranchfix #gulp testand it passes the lintNote: Requests to pull into master from a fork will be rejected.