Open
Conversation
Member
|
I think all the changes are good except using const meta = metada.get(metdata.resource, If);
meta.behaviorRequiresLifecycle = true;and check: function behaviorRequiresLifecycle(instruction) {
let t = instruction.type;
let name = t.elementName !== null ? t.elementName : t.attributeName;
return lifecycleOptionalBehaviors.indexOf(name) === -1 && (t.handlesAttached || t.handlesBind || t.handlesCreated || t.handlesDetached || t.handlesUnbind)
|| t.viewFactory && viewsRequireLifecycle(t.viewFactory)
|| instruction.viewFactory && viewsRequireLifecycle(instruction.viewFactory)
|| instruction.type.behaviorRequiresLifecycle;
}Note: naming is for discussion. |
bigopon
requested changes
Aug 21, 2018
| || t.viewFactory && viewsRequireLifecycle(t.viewFactory) | ||
| || instruction.viewFactory && viewsRequireLifecycle(instruction.viewFactory); | ||
| || instruction.viewFactory && viewsRequireLifecycle(instruction.viewFactory) | ||
| || instruction.initiatedByBehavior; |
Member
There was a problem hiding this comment.
We can not do this, as it includes all custom elements, and custom attributes, thus could possibly make it a breaking change.
db1cdc4 to
cd3e953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a crude attempt at fixing #356.
The fix for the
ifcase was relatively straight-forward. But to disable the fast-pass for the "subview without lifecycle methods" case, I had to rely oninstruction.initiatedByBehavior, because I couldn't find a better indicator.I just started working with Aurelia a few weeks ago, so I’m sure there’s a more elegant way that I couldn’t discover. Let me know what you think!