Allow pug file extensions in html-resource-plugin#385
Open
qraynaud wants to merge 1 commit intoaurelia:masterfrom
Open
Allow pug file extensions in html-resource-plugin#385qraynaud wants to merge 1 commit intoaurelia:masterfrom
qraynaud wants to merge 1 commit intoaurelia:masterfrom
Conversation
a4a92d4 to
1ce651d
Compare
Author
|
I rebased my PR hoping it would fix the tests failing. I'm glad it did ;) If you need me to improve my code over this, I'll be glad to do so. Just point me in the right direction and I'll do it. I have been running this patch in production for over a month and it seems stable enough. I hope this helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using pug & webpack and found out that
was not working.
After looking into the codebase I found out that this seems to fix the issue though I'm not sure it's the proper way to do this.
Ideally I would have loved to find a way to make this configurable in
main.jsand even the webpack aurelia pluginviewExtensionsoption to be included in environment and looked for by the generatedmain.jsfile. Maybe with something like :But it's too big a change for me at this point. And I think it would have impacts cross repositories so it's better to get things done by smaller steps I suppose.
Hope this helps!