Patogesniam tikrinimui: SF 2#305
Closed
aurelijusb wants to merge 13 commits intohomework-2019-11-14from
Closed
Conversation
So it would be easier to test, if all parts are connected correctly. Documentation: * https://help.github.com/en/actions/automating-your-workflow-with-github-actions * https://symfony.com/doc/current/routing.html#debugging-routes
So it would be clear, that all parts are working correctly, leaving more time to Code review. Adding screenshots and debugging intermediate results, so it would be faster to evaluate and/or fix issues. Using Cypress as one of Headless browser based test framework. Cypress is running browser as a separate process, so it was needed for custom debug function to see intermediate results in GitHub actions as well. Using e2e-tests.sh to reach docker network used by docker-compose.yml. Initial idea was to use GitHub Checks Annotations, but Cypress already formats output with colors. So using just different indentation. Video recording disabled to not abuse GitHub – it already does tremendous job. Using GitHub Action "if: always()" to store screenshots for both successful builds and errors. Documentation: * https://www.cypress.io/ * cypress-io/cypress#3199 * https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#set-a-warning-message-warning * https://help.github.com/en/actions/automating-your-workflow-with-github-actions/contexts-and-expression-syntax-for-github-actions#job-status-check-functions
Intention is to create similar project in symfony, as is deployed on https://hw1.nfq2019.online Note: https://hw1.nfq2019.online/students.json can be useful.
To cover other edge cases.
There was an error in https://hw1.nfq2019.online/ There should be 51 real students instead of 46 unique names.
Owner
Author
|
Čia tik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased: #199