Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very small PR which adds a more detailed progress bar to the
ParticleSimulation::Execute(). Previous iteration would check if 25%, 50% and 75% of the total work had been completed. New implementation abstracts out to a separate method that calls a for loop over 10 iterations (in practices could be any denomination of 100) and checksif workComplete == (i*TotalWork)/10. Perhaps this would cause some slowdown. Before merging this in with master maybe some profiling should be completed. Full changelist below:Changelist
private ParticleSimulation::update_progress_indicator()method that calls to update the progress indicator every 10% that is complete. This works for both the dynamic_mpi and serial runs (may need a different function for no_load_balanced_mpi)mainfunction that queries the json for an"global_params": {"mpi_timings"}parameter. When present and set to true AEGIS will print individual mpi rank timings to console (useful for debugging slow processes)ParticleSimulation::exeTypetoParticleSimulation::execution_typeto be more explicit in its intentParticleSimulation::mpi_particle_stats()method is now only called when"aegis_params": {"print_mpi_particle_stats": true}