Skip to content

Rebuild a0 solver in ScalarPotentialSource when Apply called #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EdwardPalmer99 wants to merge 1 commit into from
Closed

Rebuild a0 solver in ScalarPotentialSource when Apply called #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/sources/scalar_potential_source.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,8 @@ ScalarPotentialSource::Apply(mfem::ParLinearForm * lf)
_a0->FormLinearSystem(
poisson_ess_tdof_list, phi_gf, *_b0, *_diffusion_mat, *_p_tdofs, *_b0_tdofs);

if (_a0_solver == nullptr)
{
_a0_solver = std::make_unique<hephaestus::DefaultH1PCGSolver>(_solver_options, *_diffusion_mat);
}
// Solve
_a0_solver = std::make_unique<hephaestus::DefaultH1PCGSolver>(_solver_options, *_diffusion_mat);
Copy link
Contributor

@alexanderianblair alexanderianblair Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big performance hit here if a0_solver does not need to be reused; but necessary for mesh updates, since the solver will need to be rebuilt then. Rebuild could go into an Update() method?

_a0_solver->Mult(*_b0_tdofs, *_p_tdofs);

// "undo" the static condensation saving result in grid function dP
Expand Down