Rebuild a0 solver in ScalarPotentialSource when Apply called#112
Closed
EdwardPalmer99 wants to merge 1 commit intoEdwardPalmer99/mesh-update-feature-branchfrom
Conversation
Required for updates to work correctly. Refer to TestTEAM4HFormMeshUpdates test.
EdwardPalmer99
changed the base branch from
master
to
EdwardPalmer99/mesh-update-feature-branch
EdwardPalmer99
changed the title
| _a0_solver = std::make_unique<hephaestus::DefaultH1PCGSolver>(_solver_options, *_diffusion_mat); | ||
| } | ||
| // Solve | ||
| _a0_solver = std::make_unique<hephaestus::DefaultH1PCGSolver>(_solver_options, *_diffusion_mat); |
Contributor
There was a problem hiding this comment.
Big performance hit here if a0_solver does not need to be reused; but necessary for mesh updates, since the solver will need to be rebuilt then. Rebuild could go into an Update() method?
Contributor
|
Closing in favour of #113, which includes a test with mesh updates that requires this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.