Implement backup and restore for fixed point iteration changes by mattfalcone1997 · Pull Request #65 · aurora-multiphysics/hippo

mattfalcone1997 · 2025-07-11T16:15:45Z

Summary

Implement backup and restore functionality for the data from OpenFOAM to allow fixed point iteration to be used with MOOSE. A potential advantage to be explored:

TFFB boundary coupling could be used with larger time steps by using Picard iteration to converge the boundary.
Allow more complex systems to be more tighly coupled

Maybe look to reproduce in the laplacianTestSolver

Related Issue

Resolves #21

Checklist

…ot implemented yet

…teration

k-collie

Initial comments before rebase and looking at tests

test/OpenFOAM/foam_modules.mk

Makefile

include/base/foam/fvCFD_moose.h

include/base/FoamSolver.h

src/problems/FoamProblem.C

src/mesh/FoamMesh.C

include/mesh/FoamDataStore.h

…re not backed up. Also make changes based on code review

k-collie

I have to check the tests a bit but here's some comments.

include/mesh/FoamDataStore.h

…ime schemes

k-collie

Tests look pretty good overall I think, just a few things.

include/base/FoamSolver.h

test/OpenFOAM/modules/functionTestSolver/functionTestSolver.H

test/OpenFOAM/modules/laplacianTestSolver/laplacianTestSolver.H

test/OpenFOAM/modules/odeTestSolver/odeTestSolver.H

test/tests/fixed-point/README.md

test/tests/fixed-point/ode_euler/test.py

test/tests/fixed-point/unsteady_heat_conduction/test.py

test/tests/fixed-point/heated_plate_converge/test.py

test/tests/fixed-point/restart_heated_plate/test.py

test/tests/fixed-point/restep_fixed_point/test.py

definitions

reference cases on the fly

test/tests/multiapps/unsteady_heat_conduction_in_infinite_system/run.i

k-collie

Thanks for enduring my review Matt! Good job

mattfalcone1997 mentioned this pull request Jul 11, 2025

Implement backup and restore #64

Closed

mattfalcone1997 force-pushed the implement_backup_and_restore branch from 3dc23f7 to 971b985 Compare August 8, 2025 15:17

mattfalcone1997 added 28 commits October 22, 2025 15:22

Update latest fixed point changes

1fb7ede

Implement initial maybe working implementation

0391a3b

Update backup so it is placed in the FoamSolver class

c43c642

Update checkField to use method as the storeField functions

a1e01e8

Remove some asserts from FoamSolver

cb26764

Allow any OpenFOAM solver to be used inHippo

ec82603

Use new approach to copy OpenFOAM field data

778cc67

Clean up unused functions

afa732a

Move DataStore to separate file and move to problem

b088994

Add placeholder implementation of reconverable data with field read n…

d0dd8d4

…ot implemented yet

Initial implementation of dataStore and dataLoad

bf1cb20

Implement dataStore/dataload as template

06a0242

Add serialisation/deserialisation for old time fields

0d47839

Update exodus data reader to removed deprecation warning

f705bb8

Add serial unsteady heat conduction test for fixed point

e1edb09

Implement simplified backup and restore

c901084

Fix simplified implementation

3418987

Remove uneeded FoamDataStore class

6dd1c88

simplify further dataStore/dataLoad templates

be766c1

Update field output method for testing

63bb028

Ensure new method gives same result as previous

64ff1b1

Optional allow storing of derived types

89d09f7

implement minor improvements to dataStore

00732e1

Ensure dataStore stream can fully hold double precision

a42f98a

Rremove unnecessary implementations of preBackup and postRestore

83c8b7c

Add initial implementation of OpenFOAM test modules for fixed-point i…

33fc8ba

…teration

Fix Crank-Nicolson fixed-point for the internal fields

a834713

Implement simple function test for fixed-point

800b5a1

k-collie reviewed Nov 10, 2025

View reviewed changes

mattfalcone1997 added 3 commits November 12, 2025 10:13

Update code after initial review

d745927

Merge branch 'main' into implement_backup_and_restore

7cf3fcd

Update fixed point tests to use new transfer system

d434b26

k-collie reviewed Dec 9, 2025

View reviewed changes

src/mesh/FoamMesh.C Show resolved Hide resolved

include/mesh/FoamDataStore.h Outdated Show resolved Hide resolved

include/mesh/FoamDataStore.h Outdated Show resolved Hide resolved

include/mesh/FoamDataStore.h Show resolved Hide resolved

Add debug code to print list of backed-up fields and mesh keys that a…

40904c9

…re not backed up. Also make changes based on code review

mattfalcone1997 requested a review from k-collie December 23, 2025 14:42

mattfalcone1997 added 2 commits December 23, 2025 14:50

Add comment to note about the differences in behaviour if CN is used

b615244

Eliminate use of static variable for storing field names for debugging

f554af1

mattfalcone1997 requested review from k-collie and removed request for k-collie January 8, 2026 16:04

Use MooseInfoRepeated for outputting debug information

1aeed39

k-collie requested changes Jan 9, 2026

View reviewed changes

include/mesh/FoamDataStore.h Show resolved Hide resolved

include/mesh/FoamDataStore.h Show resolved Hide resolved

mattfalcone1997 added 2 commits January 9, 2026 16:49

Add warning to explain potential issues with fixed-point at certain t…

5b8b922

…ime schemes

Remove unnecessary context passes in FoamDataStore

824025c

mattfalcone1997 requested a review from k-collie January 9, 2026 17:29

k-collie reviewed Jan 13, 2026

View reviewed changes

mattfalcone1997 added 5 commits January 14, 2026 12:51

Update description for test solvers

73bc5e9

Update fixed-point test README.md

109eb76

Apply comments from review and apply ruff formatter to python files

094345f

Allow tests to run with latest version of MOOSE

a7d0642

Update OpenFOAM test modules to remove unnecessary member function

d6c54dc

definitions

mattfalcone1997 requested a review from k-collie January 14, 2026 14:25

mattfalcone1997 added 2 commits January 14, 2026 18:02

Remove unused member functions from FoamSolver.h

5649549

Remove tar.gz files from small fixed-point tests by running the

15ca035

reference cases on the fly

k-collie reviewed Jan 15, 2026

View reviewed changes

test/tests/multiapps/unsteady_heat_conduction_in_infinite_system/run.i Outdated Show resolved Hide resolved

Fix capitalisation on test input file

8fa0e50

k-collie approved these changes Jan 15, 2026

View reviewed changes

mattfalcone1997 merged commit 44b15e8 into aurora-multiphysics:main Jan 15, 2026
2 checks passed

mattfalcone1997 deleted the implement_backup_and_restore branch January 15, 2026 16:26

Conversation

mattfalcone1997 commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Checklist

Uh oh!

k-collie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k-collie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

k-collie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k-collie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mattfalcone1997 commented Jul 11, 2025 •

edited

Loading