Conversation
…ter script into 2d_plate/
… pip install with pyproject.toml
…d building multi-classifier
lukethehuman
left a comment
lukethehuman
left a comment
There was a problem hiding this comment.
Great first pass. The code is very neat, nicely laid out, and readable, though there are a number of style improvements I've suggested which would be a big improvement. Largely these are the same suggestions you'll get automatically by using linting tools and/or pycodestyle and pydocstyle.
Taking the example file as as example of code a user might write to use Icarus, the current API requires a lot more user code than I think is necessary. It would be good to aim for an example that runs the MWE in minimal lines of code (without sacrificing customisability of the tool), alongside an example demonstrating the full customisability.
The code installed and ran successfully with a fresh build of proteus and the latest pypi version of pyvale; I've recommended simplifying the installation by version tagging pyvale in the pyproject.toml requirements.
Co-authored-by: Luke Humphrey <37630574+lukethehuman@users.noreply.github.com>
Co-authored-by: Luke Humphrey <37630574+lukethehuman@users.noreply.github.com>
Co-authored-by: Luke Humphrey <37630574+lukethehuman@users.noreply.github.com>
2 participants
No description provided.