Add coaxial junction to join two coaxial pipes together#52
Open
mattfalcone1997 wants to merge 8 commits intomainfrom
Open
Add coaxial junction to join two coaxial pipes together#52mattfalcone1997 wants to merge 8 commits intomainfrom
mattfalcone1997 wants to merge 8 commits intomainfrom
Conversation
68a32ac to
3c672e8
Compare
…all geometry changes
408f0a7 to
3724828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This junction allows the coaxial tubes of different geometries to be joined. In this implementation, both the solid region and fluid regions are connected, with the flow channels are optionally joined. This allows components such as pumps may be added. Currently, the flow junctions are assumed to have no momentum loss, which can be improved in the future if necessary.
Considerations
Testing