DYNAMIC_STREAM_METADATA should be decoupled from streamSettings#457
Open
shanshanzhu wants to merge 1 commit intoaurora-opensource:masterfrom
Open
DYNAMIC_STREAM_METADATA should be decoupled from streamSettings#457shanshanzhu wants to merge 1 commit intoaurora-opensource:masterfrom
shanshanzhu wants to merge 1 commit intoaurora-opensource:masterfrom
Conversation
Author
|
@twojtasz couldn't find streetscape on buildkite. Was that disabled? |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning:
DYNAMIC_STREAM_METADATA configuration should be decoupled from streamSettings.
Current behavior:
when DYNAMIC_STREAM_METADATA is set to true, and streamSettings is not set, the _onXVIZTimeslice throws an error for
inoperatorExpected fix:
We either need to set the default value for
streamSettingsto{}in constructor, or do a safe check forstreamSettingsas in the diff.