Skip to content

Conversation

@deep-lyra
Copy link
Contributor

@deep-lyra deep-lyra commented Jul 17, 2024

Changes

The example provided had incorrect variable used for signatureVerifier. This might cause issue for someone that is copying the example and trying to run it.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@jimmyjames
Copy link
Contributor

❤️ Nice @deep-lyra, thanks!

@tanya732 this seems like a good contribution, can you update the branch and see what's going on with CI so we can get this in?

@tanya732 tanya732 requested a review from a team as a code owner January 9, 2025 06:00
@tanya732
Copy link
Contributor

HI @deep-lyra

Thank you for the contribution.
Since the CI pipeline is failing, I have added your commits and merged them. For reference

@tanya732 tanya732 closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants