Issue #669: Allow to create ManagementAPI with a custom TokenProvider#705
Closed
kay-horst wants to merge 2 commits intoauth0:masterfrom
Closed
Issue #669: Allow to create ManagementAPI with a custom TokenProvider#705kay-horst wants to merge 2 commits intoauth0:masterfrom
kay-horst wants to merge 2 commits intoauth0:masterfrom
Conversation
0159221 to
a43b22a
Compare
a43b22a to
d87e39c
Compare
Contributor
|
Hi @kay-horst Thank you for raising the PR !! The API Diff check failed due to binary compatibility changes between versions. Specifically, it detected changes to the public API surface that break compatibility with earlier versions. I think adding a new constructor with flexibility of token provider customization is better approach. However, we need to ensure these changes remain backward-compatible to avoid breaking changes. Thank you |
Contributor
|
Hi @kay-horst The changes have been successfully released and can be found here Thank you for your contribution! Closing this as a solution has been found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added possibility to create a
com.auth0.client.mgmt.ManagementAPIinstance with an implementation ofcom.auth0.client.mgmt.TokenProviderinstead of just a fixed token string. This allows for e.g. transparent implementation of token refreshing without having to explicitly callManagementAPI.setApiToken(...), which can be done by providing an appropriateTokenProviderimplementation, which checks the expiry of the token and fetches a new one, if necessary.References
Address issue #669.
Testing
Checklist