Skip to content

Conversation

@tanya732
Copy link
Contributor

@tanya732 tanya732 commented Apr 29, 2025

Changes

  • Made show_as_button and is_domain_connection optional

References

Create Connection
Update Connection

Manual Testing

  • Get accessToken, domain from your tenant Get accessToken

ManagementAPI api = ManagementAPI.newBuilder(domain, accessToken).build();

/* Create Connection */
Connection create = new Connection("Test-Connection", "ad");
create.setDomainConnection(true);

Request<Connection> createCon = api.connections().create(create);
Response<Connection> createConRes = createCon.execute();
Connection createConResp = createConRes.getBody();

/* Update Connection */
Connection update = new Connection();
update.setShowAsButton(true);
update.setDomainConnection(true);
Connection updateConResp = api.connections().update("<ConnectionID>", update).execute().getBody();

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@tanya732 tanya732 requested a review from a team as a code owner April 29, 2025 05:30
kailash-b
kailash-b previously approved these changes May 5, 2025
kishore7snehil
kishore7snehil previously approved these changes May 5, 2025
Copy link

@kishore7snehil kishore7snehil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanya732 tanya732 dismissed stale reviews from kishore7snehil and kailash-b via ce2e488 May 5, 2025 13:44
Copy link

@kishore7snehil kishore7snehil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanya732 tanya732 merged commit d61e88a into master May 6, 2025
6 checks passed
@tanya732 tanya732 deleted the fix-connections branch May 6, 2025 05:20
@tanya732 tanya732 mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants