Skip to content

Comments

fix: handle undefined and empty domain values in HRD screen (#2526)#2720

Merged
ankita10119 merged 5 commits intomasterfrom
SDK-7528
Jan 20, 2026
Merged

fix: handle undefined and empty domain values in HRD screen (#2526)#2720
ankita10119 merged 5 commits intomasterfrom
SDK-7528

Conversation

@ankita10119
Copy link
Contributor

Description

Single AD connections without configured domains were displaying "undefined" in login messages:

  • Before: "Please enter your corporate credentials at undefined."
  • Root cause: Code only checked domain !== null but not domain !== undefined
  • Additional issue: Empty strings and whitespace-only domains also produced poor UX

Solution

Enhanced domain validation in HRDScreen component:

References

Fixes #2526

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@ankita10119 ankita10119 requested a review from a team as a code owner January 18, 2026 17:05
ankita10119 and others added 2 commits January 20, 2026 16:52
…t, function or class

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…t, function or class

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@ankita10119 ankita10119 enabled auto-merge (squash) January 20, 2026 13:26
@ankita10119 ankita10119 merged commit 2fc38f9 into master Jan 20, 2026
5 checks passed
@ankita10119 ankita10119 deleted the SDK-7528 branch January 20, 2026 15:10
ankita10119 added a commit that referenced this pull request Jan 21, 2026
**Fixed**
- fix: update className and InputWrap name in SelectInput component
(#2534) [\#2719](#2719)
([ankita10119](https://github.com/ankita10119))
- fix: handle undefined and empty domain values in HRD screen (#2526)
[\#2720](#2720)
([ankita10119](https://github.com/ankita10119))
- fix: add 'too_many_attempts' to error codes in logInError function
[\#2718](#2718)
([ankita10119](https://github.com/ankita10119))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single AD connection without domain still shows undefined in message

2 participants