feat: add error display and read/send iteration#31
Open
t-nakagawa-esol wants to merge 1 commit intoautowarefoundation:mainfrom
Open
feat: add error display and read/send iteration#31t-nakagawa-esol wants to merge 1 commit intoautowarefoundation:mainfrom
t-nakagawa-esol wants to merge 1 commit intoautowarefoundation:mainfrom
Conversation
EAGAIN , EWOULDBLOCK or EINTR for read/send function. 2. Get read/send function repeat until the size of the return value becomes the sizeof(frame). 3. Display errno for errors other than timeout in wait function.
xmfcx
requested changes
Jul 17, 2024
Comment on lines
+158
to
+160
| nbytes = ::send( | ||
| m_file_descriptor, (char *)p + bytes_sent, sizeof(data_frame) - bytes_sent, | ||
| flags); |
Contributor
There was a problem hiding this comment.
Suggested change
| nbytes = ::send( | |
| m_file_descriptor, (char *)p + bytes_sent, sizeof(data_frame) - bytes_sent, | |
| flags); | |
| nbytes = ::send( | |
| m_file_descriptor, reinterpret_cast<char *>(p) + bytes_sent, sizeof(data_frame) - bytes_sent, | |
| flags); |
Related test error: https://github.com/autowarefoundation/ros2_socketcan/actions/runs/9974311030/job/27561524880?pr=31#step:5:1406
xmfcx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation cannot distinguish between time-outs and other errors for the receive/send function.
So, we might have to add a specified number of retries for the other errors below.
EAGAIN , EWOULDBLOCK or EINTR for read/send
It might not be possible to guarantee that sizeof(frame) will always return in the return value of the read/send function
Therefore, it might be necessary to repeat until the size of the return value becomes the sizeof(frame).
In the wait function, the current implementation does not distinguish between timeouts and other errors.
Therefore, it might be necessary to display errno for errors other than timeout.