feat(core/types): Block RLP + Body hooks

[qdm12]

Why this should be merged

How this works

How this was tested

• Tested in chore(core/types): Block libevm Body and RLP hooks coreth#750
• Needs to be unit tested

[darioush]

unfortunately I think we may need to patch up Body as well, since this type is used in core/rawdb in Read/WriteBody, which we intend to use upstream code for.

The added fields are the same, so I am not sure if there is a clever way to handle them both with one registration, but having overall 3 types we patch in like this:

• Header
• Body
• Block

seems fine to me too.

[darioush]

I think this copy should be a deep copy so likely adding a method to header hooks is needed.

[qdm12]

unfortunately I think we may need to patch up Body as well

EDIT: you're right, never mind! Working on it!

Doesn't https://github.com/ava-labs/coreth/pull/750/files#diff-e177ddb5610d1f3426c15cb512999613785b20838954e48187883e6263bb282bR45 suffice? 🤔

Or at least for now, we can then do a PR for the body after to keep things tidy and one-step-at-a-time?

[darioush]

Or at least for now, we can then do a PR for the body after to keep things tidy and one-step-at-a-time?

We can merge 1 PR at a time to libevm, but I'd like to close the loop on the whole point of this exercise which is to be able to drop the core/rawdb package, to ensure there are not any more surprises that would cause re-work.

We can make the next PR to this branch if you think it's cleaner that way, so we can continue verifying the integration with coreth/subnet-evm contains everything we need before fully fleshing out tests & solidifying the changes.

[ARR4N]

Superseded by:

• feat(core/types): Header hook PostCopy #106
• feat(core/types): body RLP hooks registration #130
• Upcoming PR from me for Blockhooks