Merged
Conversation
JonathanOppenheimer
requested review from
ARR4N and
StephenButtolph
as code owners
JonathanOppenheimer
changed the title
eth_subscribe
ARR4N
previously requested changes
Feb 4, 2026
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
I mainly thought it was weird that: 1. We used subtests but they were all completely independent. I felt like we should either split them into separate top level tests, or merge them into the same test. Since all the tests are really a subset of the logs test, I decided to just merge them together. 2. The logs test didn't fully verify the expected log result, I expanded the log check to verify the full log. 3. We now test that we never get any pending logs
StephenButtolph
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More free wins with testing -- I added coverage for
newPendingTransactionsevent types (head was the single test prior). I also clarified that the three other types for subscription were intentionally no-ops.I added the supported RPCs to the list in
rpc.go