refactor: txgossip.NewBlockChain() serves executed not settled state#162
Closed
refactor: txgossip.NewBlockChain() serves executed not settled state#162
txgossip.NewBlockChain() serves executed not settled state#162Conversation
This was referenced Feb 13, 2026
Collaborator
Author
|
Unnecessary if we just return head regardless of which state root is requested (idea thanks to @StephenButtolph). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream
legacypoolimplementation expects a synchronous blockchain, initially requesting the current block and then updating based on chain-head events, in both cases opening astate.StateDBat the latesttypes.Header.Root. In an asynchronous implementation this results in the mempool acting on settled, not executed state. So far this has caused two undesirable properties:sae.VM.WaitForEvent(), only to be filtered out byworstcase. This also suggests an underlying inefficiency in which everyBuildBlock()first discards some prefix of already-included transactions.BuildBlock()method to include any transaction from an EOA with included but not settled transactions.This PR introduces a mapping from settled to latest-known execution roots, opening the latter whenever
legacypoolrequests the former. The latest-known property accounts for the fact that multiple blocks may settle the same state root while introducing different post-execution roots. Although this doesn't address all of (1) and some empty blocks and discarded prefixes can occur, it significantly curtails the issue.Instead of introducing a new test in this PR, I have demonstrated in f314e32 that this fixes the hack required by #160.