show conn reuse #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couple of comments about ur observation
why would we expect a failure on the 2nd request? a new conn would be spun up to serve it
i think there's some confusion here. you're assuming goroutine is the "connection", what actually happens is the middleware server starts up a http server that accepts new http conns. the http server likely itself is a long running goroutine. when receiving requests, it'll spin up additional goroutines to handle the request. ur sleep is in that goroutine. if u want that app logic to be context aware, a sleep will not work (its blocking). you can use a select instead:
the code i changed uses
httptraceto inspect the connection state. im trying to point out the scenario where a conn is reused or created. the 1st and 2nd show that a timeout causing the next conn to be new. whereas the 3rd and 4th show that with no timeout, a conn is reused