Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
moraesjeremias
requested changes
Sep 8, 2025
Member
moraesjeremias
left a comment
moraesjeremias
left a comment
There was a problem hiding this comment.
Can you please rebase? There're conflicts.
# Conflicts: # script/bin/operator.rs # services/bin/indexer.rs # services/src/types.rs
moraesjeremias
approved these changes
Sep 9, 2025
| let proof = prover_client.prove(&self.pk, &stdin).plonk().run()?; | ||
| Ok(proof) | ||
| } else { | ||
| let spn = env::var("SP1_PROVER")?.to_lowercase() == "network"; |
Member
There was a problem hiding this comment.
Doesn't sp1-sdk@v5.2.1 has reserved a network implementation at all?
Just trying to understand a possible conflict if we forget to specify succinct's public rpc endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.