Skip to content

make squash command add some visual feedback that the squash is running#574

Open
tulioz wants to merge 1 commit intomasterfrom
make_squash_show_progress
Open

make squash command add some visual feedback that the squash is running#574
tulioz wants to merge 1 commit intomasterfrom
make_squash_show_progress

Conversation

@tulioz
Copy link
Contributor

@tulioz tulioz commented Jul 30, 2025 •
edited
Loading

No description provided.

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 30, 2025

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@tulioz tulioz force-pushed the make_squash_show_progress branch from 0b02e81 to ab009af Compare July 30, 2025 20:47
@tulioz tulioz force-pushed the make_squash_show_progress branch from ab009af to d00ac76 Compare July 31, 2025 07:07
@tulioz tulioz marked this pull request as ready for review July 31, 2025 07:08
@tulioz tulioz requested a review from a team as a code owner July 31, 2025 07:08
@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 31, 2025 •
edited
Loading

✅ FlexReview Status

Common Owner: aviator-co/engineering (expert-load-balance assignment)
Owner and Assignment:

  • ✅ aviator-co/engineering (expert-load-balance assignment)
    Owned Files
    • cmd/av/squash.go

Review SLO: 7 business hours if PR size is <= 200 LOC for the first response.

@aviator-app aviator-app bot requested a review from sarahannali July 31, 2025 07:08
@tulioz tulioz requested a review from draftcode July 31, 2025 07:08
@tulioz
Copy link
Contributor Author

tulioz commented Jul 31, 2025

@Brookke making some small changes to the squash command, would love your feedback as well if you have any thoughts.

@tulioz tulioz removed the request for review from sarahannali August 4, 2025 20:22
@Brookke
Copy link
Contributor

Brookke commented Aug 5, 2025

@Brookke making some small changes to the squash command, would love your feedback as well if you have any thoughts.

awesome @tulioz looking now

@Brookke
Copy link
Contributor

Brookke commented Aug 5, 2025

Looks good!

However, realised I have a bug in this and the current prod version where it squashes one too many commits 🤦🏻 I probably missed this in my PR due to my too simple testing setup. @tulioz

Brookke
Brookke reviewed Aug 5, 2025
View reviewed changes
cmd/av/squash.go
colors.Success(fmt.Sprintf("Successfully squashed %d commits", len(commitIDs))),
"\n",
)
fmt.Fprint(os.Stderr, amendMessage, "\n\n")
Copy link
Contributor

@Brookke Brookke Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should still include the amendMessage? it gives a nice summary of what the squash did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Brookke Brookke Brookke left review comments

@draftcode draftcode draftcode approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tulioz @Brookke @draftcode