Skip to content

Conversation

@avidan-H
Copy link
Owner

Status

Ready/In Progress/In Hold(Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Related PRs

List related PRs against other branches:

branch PR

Required version of Demisto

x.x.x

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation (with link to it)
  • Code Review

Dependencies

Mention the dependencies of the entity you changed as given from the precommit hooks in checkboxes, and tick after tested them.

  • Dependency 1
  • Dependency 2
  • Dependency 3

Additional changes

Describe additional changes done, for example adding a function to common server.

Technical writer review

Mention and link to the files that require a technical writer review.

dantavori and others added 30 commits October 3, 2019 13:08
* rasterize: phantomJS -> chrome

* getArg -> args().get

* 5.0 -> 5.0.0

* rast_image

* image

* commit

* rasterize 4.5

* todos

* toversion

* mypy

* new image

* better test

* unitests

* flake8

* test data

* unitests

* unitests

* unitests

* unitests...

* unitests...

* unitests

* InfoFile

* unmockable

* yuval's changes

* unitests

* Update Integrations/rasterize/CHANGELOG.md

Co-Authored-By: Guy Lichtman <1395797+glicht@users.noreply.github.com>

* Updated descriptions.
orenzohar and others added 28 commits October 22, 2019 10:49
EmailAuthenticityCheck description update.
* fix first fetch default value

* Updated new parameter display name.

* Updated description.
* fix last_fetch in fetch incidents

* mypyy

* changelog

* Updated description

* Minor edit.

* limit to 50 incidents, sort incidents

* fix unit test

* removed limit of 5 fetches

* fix date

* fix date

* fix test
…lDomainWhitelist_blacklist

* 'master' of https://github.com/demisto/content: (68 commits)
  proofpoint: fix fetch incidents (demisto#4599)
  Fix first fetch default value (demisto#4486)
  DMARC Tags fix
  SplunkPy - improved app parameter handling (demisto#4592)
  File convert: convert files using Libre Office (demisto#4578)
  Updated descriptions.
  fix docker image and secrets validation (demisto#4612)
  insecure
  Changelog
  API Token param -> encrypted
  mypy type ignore added
  mypy fix
  mypy fix
  fixed error message
  fixed required changes
  Update Integrations/Palo_Alto_Networks_WildFire_v2/CHANGELOG.md
  Updated description
  changelog
  fix Process Email Generic - Test
  Updated description
  ...
…undisto/content into emailDomainWhitelist_blacklist

* 'emailDomainWhitelist_blacklist' of https://github.com/tundisto/content:
  Updated descriptions.
  Updated descriptions.
update Logrhythm SOAP test and remove Logrhythm Rest test from skipped
Fixed array handling in Splunk notable to incident
* Add list_pr_review_comments_command

* Fix typo in list_pr_review_comments_command

* Add update_pull_request_command

* Add is_pr_merged_command

* Fix is_pr_merged_command

* Add create_pull_request_command

* Update changelog

* Fix linting

* Shift API call functions atop each one's associated command function

* Update test playbook to include new commands

* Update test playbook - verify command executions

* Update GitHub.yml

Reviewed and updated

* Fix yml syntax
…acklist

Added EmailDomainWhitelist / EmailDomainBlacklist transformers (supersedes 3490)
* add parse html

* change docker image ci

* change excetion type and raise the exception so it will not be able to continue.
demisto#4646)

* SlashNext: Submitting SlashNextPhishingIR application to be reviewed … (demisto#4420)

* SlashNext: Submitting SlashNextPhishingIR application to be reviewed by Demisto team.

Signed-off-by: Saadat Abid <saadatabid@gmail.com>

* SlashNext: Addressed review comments by Itay Keren.

Signed-off-by: Saadat Abid <saadatabid@gmail.com>

* SlashNext: Added the generated Integration documentation.

Signed-off-by: Saadat Abid <saadatabid@gmail.com>

* SlashNext: Developed the test playbook for SlashNext Phishing Incident Response integration.

Signed-off-by: Saadat Abid <saadatabid@gmail.com>

* SlashNext: Developed unit tests for SlashNext Phishing Incident Response integration.

Signed-off-by: Saadat Abid <saadatabid@gmail.com>

* SlashNext: SlashNext links/pharses were added to whitelist.

Signed-off-by: Saadat Abid <saadatabid@gmail.com>

* improve argument description

* Updated descriptions

* Updated description.

* Updated descriptions

* Fixed small typos

* handle proxy and unsecure

* disable unverified warnings
* handle proofpoint v3

* update test playbook to check proofpoint v3 link

* Updated description.
1. Fix checking README.md files not in integration location.
2. Variable declaration fix.
Update type of values in last run dict
* Update how to recheck license cla

* better text

* Add 'cla-assistant.io' url to secrets whitelist
@avidan-H
Copy link
Owner Author

Minemeld Miners to Demisto Integrations
Minemeld Miners Demisto Integrations
Config 55601
  • aws.AMAZON
  • aws.CLOUDFRONT
  • aws.EC2
  • aws.S3
  • alienvault.reputation
  • azure.cloudIPs
  • bambenekconsulting.c2_dommasterlist
  • bambenekconsulting.c2_dommasterlist_high
  • bambenekconsulting.c2_ipmasterlist
  • bambenekconsulting.c2_ipmasterlist_high
  • bruteforceblocker.blist
  • feodotracker.ipblocklist
  • spamhaus.DROP
  • spamhaus.EDROP
  • o365-api.worldwide-any
  • o365-api.worldwide-exchange
  • dshield.block
  • blocklist_de.all
  • sslabusech.ipblacklist
  • malwaredomainlist.ip
  • abusech-SSL-Blacklist-Feed.yml
  • AlienVault-Reputation-Feed.yml
  • AWS-Feed.yml
  • Azure-Feed.yml
  • Bambenek-Consulting-Feed.yml
  • Blocklist_de-Feed.yml
  • BruteForceBlocker-Feed.yml
  • Dshield-Feed.yml
  • Feodo-Tracker-IP-Blocklist-Feed.yml
  • Malware-Domain-List-Active-IPs-Feed.yml
  • Office365-Feed.yml
  • Recorded-Future-Feed.yml
  • Spamhaus-Feed.yml
  • Tor-Exit-Addresses-Feed.yml
Config 22477
  • alienvault.reputation
  • bambenekconsulting.c2_ipmasterlist_high
  • bambenekconsulting.c2_dommasterlist_high
  • dshield.block
  • spamhaus.DROP
  • spamhaus.EDROP
  • tor.exit_addresses
  • AlienVault-Reputation-Feed.yml
  • Bambenek-Consulting-Feed.yml
  • Dshield-Feed.yml
  • Spamhaus-Feed.yml
  • Tor-Exit-Addresses-Feed.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.