Open
Conversation
mounchin
reviewed
Mar 4, 2025
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: {{ include "neuron-node-problem-detector-and-recovery.namespace" . }} |
Contributor
There was a problem hiding this comment.
Sometimes I have seen clusters already having neuron-healthcheck-system namespace when created, causing helm deployment failure due to ownership issues, so we have not added the namespace.
Author
There was a problem hiding this comment.
What is the use case when exactly this namespace is created? In that case we can set npd to use different namespace?
Alternatively I think this requirement should be added to the readme.
Contributor
There was a problem hiding this comment.
I'm not 100% sure when this ns is created tbh, yes we can update the readme to create the npd namespace if does not exist. Alternatively we can control this behavior using a flag to create a ns, by default its off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
During testing I got errors of missing namespace for NPD.