Skip to content

refactor(logger): replace lodash.merge with internal deepMerge utility #4892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jaimellamasi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(logger): replace lodash.merge with internal deepMerge utility #4892

jaimellamasi wants to merge 2 commits into from
+3,104 −2,977

Conversation

@jaimellamasi
Copy link
Contributor

@jaimellamasi jaimellamasi commented Dec 20, 2025

Summary

Changes

  • Removes lodash.merge dependency from logger package
  • Adds new deepMerge utility to commons package
  • Includes prototype pollution and circular reference protection

Issue number: closes #4846

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Dec 20, 2025
@boring-cyborg boring-cyborg bot added commons This item relates to the Commons Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. logger This item relates to the Logger Utility tests PRs that add or change tests labels Dec 20, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

commons This item relates to the Commons Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. logger This item relates to the Logger Utility size/XL PRs between 500-999 LOC, often PRs that grown with feedback tests PRs that add or change tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Maintenance: Replace lodash.merge with a custom deep merge utility function

2 participants

@jaimellamasi @jllamasi