This repository was archived by the owner on Jul 20, 2022. It is now read-only.
Code samples for "Power your Redshift Analytics With Apache Spark and… #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhyae
reviewed
Sep 15, 2016
| @@ -0,0 +1,29 @@ | |||
| -- Create table weather | |||
| CREATE EXTERNAL TABLE IF NOT EXISTS w ( | |||
There was a problem hiding this comment.
suggest to use a more descriptive name than 'w'
sandhyae
reviewed
Sep 15, 2016
| -- Create a database table with data for all flights in December 2013 | ||
| create table all_flights | ||
| ( | ||
| ORD_DELAY_ID bigint identity(0,1), |
There was a problem hiding this comment.
ord_delay_id as primary key is confusing, can we consider renaming
sandhyae
reviewed
Sep 15, 2016
| """ | ||
| from pandas.tseries.holiday import USFederalHolidayCalendar | ||
| calendar = USFederalHolidayCalendar() | ||
| holidays = calendar.holidays(start_date, end_date) |
There was a problem hiding this comment.
why only look for holidays in the present month, if the day passed in is the last day in month, nearest holiday could also be in the next month
sandhyae
suggested changes
Sep 15, 2016
sandhyae
left a comment
sandhyae
left a comment
There was a problem hiding this comment.
reconsider the logic in f_days_from_holiday, at present it only looks at present month
|
|
||
| // Instance Profile for authentication to AWS resources | ||
| val provider = new InstanceProfileCredentialsProvider() | ||
| val credentials: AWSSessionCredentials = provider.getCredentials.asInstanceOf[AWSSessionCredentials] |
There was a problem hiding this comment.
How can I use this in PySPARK?
thanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Amazon ML" blog