Prevent failure when no changes to stack#16
Open
darrenkidd wants to merge 1 commit intoaws-samples:mainfrom
Open
Prevent failure when no changes to stack#16darrenkidd wants to merge 1 commit intoaws-samples:mainfrom
darrenkidd wants to merge 1 commit intoaws-samples:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number: #10
Description of Changes:
As suggested in the issue noted above,
sam deployprovides an extra arg called--no-fail-on-empty-changesetwhich stops it returning a non-zero exit code when there is nothing to do. This PR adds this argument in to the template/example here which would resolve the issue.See also the SAM CLI documentation: https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-cli-command-reference-sam-deploy.html
Not a complicated change (surprised someone else hadn't already submitted a PR?). I've done a run-through locally and the arguments all seem to interact with each other OK.
In my mind, this seems like a sensible parameter to include here as we are dealing with CI/CD, not guided deployments.
(Note that we could potentially also add in
--no-confirm-changesetwhich I've used before in my projects as well.)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.